← Commit history

THE RESURRECTION GUARD (ralph found it): a reaped session's badge kept reappearing because applyAppOverlay is reached from several deferred setTimeout retries (favicon retry, post-nav re-assert, crash-heal) that CAPTURE the session object - after the window closed, those late calls recomposed and REWROTE the badge PNG for a dead session, so the reconciler deleted it and the stale paint recreated it every 8s forever (log showed 'deleted orphaned badge for ralph-reap' on a loop). Fix: applyAppOverlay now refuses at the top to paint any session that is no longer live - not in the sessions map, or all its windows closed. This is the choke point every deferred paint funnels through, so it kills the ghost from all of them at once. Combined with 1.9.279-280 (the reconciler + orphan-badge sweep), a closed window now truly leaves nothing behind: no model entry, no badge, no served icon.

John Lauer ·0a730ab5f5 ·3mo ago ·parent 7e88bea
4 files changed +14−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.280",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.280/adom-bridge-puppeteer-v1.9.280.zip",-  "sha256": "f3e3ad32347b83745294f12c2a1300c406cc45085d1a99ebd1eddb3409facc1b",-  "size": 712299,+  "version": "1.9.281",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.281/adom-bridge-puppeteer-v1.9.281.zip",+  "sha256": "466b220386ab0f4e7ce9213b65aa927c042c9738031ea03660de1fad2b989054",+  "size": 712624,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.280+1.9.281
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.280",+  "version": "1.9.281",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+8
@@ -4182,6 +4182,14 @@ async function applyAppOverlay(session, sessionId) {   // stamps NO identity and rebuilds NO jump list, but it DOES wear one composed badge per window.   if (process.platform !== 'win32' || _identitySupported !== true) return false;   if (pupSettings().overlayBadges !== 'on') return false;   // v1.9.259 user pref+  // v1.9.281 THE RESURRECTION GUARD (found by ralph: a reaped session's badge kept reappearing).+  // applyAppOverlay is reached from several deferred setTimeout retries (favicon retry, post-nav,+  // heal) that CAPTURE the session object. If the window closed in the meantime, those late calls+  // recomposed and rewrote the badge PNG for a DEAD session — so the reconciler deleted it and the+  // stale paint immediately recreated it, forever. Refuse to paint a session that is no longer live+  // (dropped from the map, or all its windows closed). This is the choke point that kills the ghost.+  if (!sessions.has(sessionId)) return false;+  { const _live = sessions.get(sessionId); let _open = false; for (const t of ((_live && _live.tabs) || [])) { try { if (t && t.page && !t.page.isClosed()) { _open = true; break; } } catch (e) {} } if (!_open) return false; }   try {     // v1.9.0: reflect the ACTIVE tab (John: favicons are more useful than counts — show what     // the user is looking at). Falls back to session.page.