← Commit history

Remove the baked Adom-mark from the notch (John: it sabotages the clean-background purpose and bleeds through the transparent overlay favicon). The notch is now a clean EMPTY transparent cutout so the taskbar shows through behind the overlay; overlay presence is guaranteed by the 4s enforcer + event triggers, so no fallback mark is needed. Bumped icon gen i5->i6 to regenerate mark-free tiles + re-stamp.

John Lauer ·09817433dc ·3mo ago ·parent 76a1896
4 files changed +13−21
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.336",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.336/adom-bridge-puppeteer-v1.9.336.zip",-  "sha256": "378c5ff9d3729ac785265284e2d8bc36ba5a27adce7a79aa343c09e7003fafc2",-  "size": 629812,+  "version": "1.9.337",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.337/adom-bridge-puppeteer-v1.9.337.zip",+  "sha256": "65717a4229e993c2ab7ac0e4da6e1142ce0db20b7a13242efe56b76a73e9b10a",+  "size": 629693,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.336+1.9.337
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.336",+  "version": "1.9.337",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7−15
@@ -3060,7 +3060,7 @@ const PUP_ICON_DEFAULT = 'pup-cat-default9.ico'; // already-created ones white, because their tiles were baked while the AUMID was still unbranded. // Folding a generation token into the appId turns an icon change into a NEW appId, which forces the // shell to create a NEW button, which is the ONLY thing that repaints. Cost is one button rebuild.-const PUP_ICON_GEN = 'i5';   // i5: near-sharp square notch (even L-margin around the overlay). BUMPED because the+const PUP_ICON_GEN = 'i6';   // i6: EMPTY transparent notch (removed the baked Adom-mark that bled through the overlay). BUMPED because the // icon FILES changed — the AUMID appId carries this token, so a new gen forces Windows to CREATE A NEW // BUTTON that reads the new (notched) icon. Same-appId re-stamps do NOT repaint a baked Win11 tile, which // is why the notch never appeared on the live button until this bump. (i3 = pre-notch PNG-frame icons.)@@ -3175,20 +3175,12 @@ async function _buildNotchedIco(sharp, srcPath, destPath) {     // (bottom-left) corner stays on-canvas and shows the radius — the notch reads as a square opening,     // not a circular blob. Matches the square overlay favicon.     const mask = Buffer.from(`<svg xmlns="http://www.w3.org/2000/svg" width="${N}" height="${N}"><rect x="${N - s}" y="${-over}" width="${s + over}" height="${s + over}" rx="${rx}" ry="${rx}" fill="#fff"/></svg>`);-    let png = await sharp(base).composite([{ input: mask, blend: 'dest-out' }]).png().toBuffer();   // dest-out punches a transparent notch-    // v1.9.329 (John: "if there's no overlay icon, the notch looks retarded"). GRACEFUL FALLBACK: drop-    // a small Adom mark centered in the notch, baked into the STATIC tile (no churn). A window that is-    // momentarily WITHOUT a live favicon overlay (e.g. right after a bridge respawn, before its hwnd-    // re-resolves) then shows a tidy branded corner instead of a raw transparent hole. When the real-    // favicon overlay IS present, AD paints it on top and it covers this.-    try {-      const markB64 = pupBadgeB64();-      if (markB64) {-        const ms = Math.round(s * 0.56);-        const mark = await sharp(Buffer.from(markB64, 'base64')).resize(ms, ms, { fit: 'contain', background: { r: 0, g: 0, b: 0, alpha: 0 } }).png().toBuffer();-        png = await sharp(png).composite([{ input: mark, top: Math.round((s - ms) / 2), left: (N - s) + Math.round((s - ms) / 2) }]).png().toBuffer();-      }-    } catch (e) {}+    // v1.9.337 — REVERT the baked Adom-mark fallback (John, rightly): baking a mark into the notch+    // sabotages the whole point (the taskbar showing through cleanly) AND it BLEEDS THROUGH the often-+    // transparent overlay favicon painted on top. The notch stays a clean, EMPTY transparent cutout —+    // nothing goes in it. The overlay is kept reliably present by the 4s enforcer + the per-event+    // recompute triggers, so a persistently-empty notch isn't a real state to paper over.+    const png = await sharp(base).composite([{ input: mask, blend: 'dest-out' }]).png().toBuffer();   // dest-out punches a transparent notch; nothing else     frames.push({ size: N, png });   }   fs.mkdirSync(path.dirname(destPath), { recursive: true });