← Commit history

Fix bridge instability on heavy pages (John: a heavy page should never crash the bridge; CDP mishandling). neutralizeDebugger kept Debugger.enable on for every tab's whole life, which streams a Debugger.scriptParsed event for every script the page parses — thousands on a heavy Babylon.js bundle — flooding the bridge's single event loop and de-opting V8; under concurrent heavy-page opens the loop starved and AD couldn't reach the bridge (error sending request). Now it disables Debugger right after clearing any inherited pause and detaches the session: freeze immunity kept (a page debugger; is a no-op with no client holding the domain), flood + de-opt + per-tab session leak gone.

John Lauer ·02225bc4e3 ·2mo ago ·parent d97837a
4 files changed +18−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.346",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.346/adom-bridge-puppeteer-v1.9.346.zip",-  "sha256": "c9a48151d14a1ab78b96d33e62ed66e6c8ae319196fcaef61f3aae5e984ca2dd",-  "size": 636218,+  "version": "1.9.347",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.347/adom-bridge-puppeteer-v1.9.347.zip",+  "sha256": "5a97672de93fa2d498d1fd1c50aaf83b9d66514d984827e6838fc932000e9498",+  "size": 636551,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.346+1.9.347
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.346",+  "version": "1.9.347",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+12−2
@@ -490,8 +490,18 @@ async function neutralizeDebugger(page) {     const cdp = await page.target().createCDPSession();     await cdp.send('Debugger.enable').catch(() => {});     await cdp.send('Debugger.setSkipAllPauses', { skip: true }).catch(() => {});-    await cdp.send('Debugger.resume').catch(() => {}); // clears a pause already freezing the window-    try { page.__pupDbgCdp = cdp; } catch (e) {} // keep a ref so the session (and the skip) survive+    await cdp.send('Debugger.resume').catch(() => {}); // clears any pause inherited at attach time+    // v1.9.347 (John: "a heavy page should NEVER crash your bridge; you're mishandling the CDP interface").+    // The 1.9.341 version KEPT the Debugger domain enabled for the tab's whole life. That makes Chrome+    // stream a Debugger.scriptParsed event for EVERY script the page ever parses — on a heavy bundle (a+    // Babylon.js 3D viewer is thousands of scripts) that is a flood of CDP messages processed on the+    // bridge's single event loop, plus V8 runs de-optimized while Debugger is on. Under concurrent+    // heavy-page opens it starved the loop so AD could not reach the bridge ("error sending request").+    // FIX: DISABLE Debugger right after clearing any inherited pause. With no client holding the domain,+    // a page's `debugger;` is a no-op anyway — so we keep the freeze immunity WITHOUT the scriptParsed+    // flood or the de-opt, and we detach the session instead of leaking one per tab.+    await cdp.send('Debugger.disable').catch(() => {});+    await cdp.detach().catch(() => {});   } catch (e) {} }