← Commit history

Set the thumbnail tooltip from updateTabCountBadge so the normal open path gets one (it was only wired into refreshWindowChrome and the category-change hook, so freshly opened windows had no tooltip)

John Lauer ·00740933ad ·3mo ago ·parent 0aeb423
4 files changed +13−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.58",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.58/adom-bridge-puppeteer-v1.9.58.zip",-  "sha256": "31ca4507716f425213f70dee7e1d2a77cf3624d837ecd8d7e7a5b4e7302ba74b",-  "size": 302413,+  "version": "1.9.59",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.59/adom-bridge-puppeteer-v1.9.59.zip",+  "sha256": "3a638f12d819327639bf6ebfb958d5c94f2c33b60d5770187a3c9bcd1f70b15b",+  "size": 302619,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.58+1.9.59
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.58",+  "version": "1.9.59",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7
@@ -2337,6 +2337,13 @@ async function updateTabCountBadge(session, sessionId) {   if (process.platform !== 'win32' || _identitySupported !== true) return; // overlay busy with brand badge on old AD   // v1.9.31: a tab verb just ran — cheap moment to notice a drag-out (event-driven, not a scan).   drainWindowOpenedEvents().catch(() => {});+  // v1.9.59: refresh the hover-preview TOOLTIP here. It was only wired into refreshWindowChrome+  // (drag-out / reclaim / relaunch) and the category-change hook, so the NORMAL OPEN PATH — which+  // calls brandPupWindow directly and never touches either — never set a tooltip at all, and no+  // window that just opened had one. This function is the right home: it already runs on open and on+  // every tab open/close, which is exactly when the tooltip's content (category + tab count) changes.+  // It is idempotent (session._thumbTip) so repeat calls cost nothing.+  updateThumbnailTooltip(session, sessionId).catch(() => {});   // v1.9.22: if the window's CATEGORY changed (a tab made it mixed, a navigate left the wiki...),   // re-stamp the base icon NOW — the 10-minute brand debounce is for redundant re-stamps of the   // SAME icon, not for a category flip the user should see immediately.