NB - Native Browser Bridge

@@ -269,7 +269,13 @@ function registerProvisional(sock) { // Edge autofill them at login time). A browser EXTENSION can't read this (sandbox); the bridge runs // natively, so it reads the `Login Data` SQLite for BOTH Chromium browsers. Dependency-free leaf reader. const LOCALAPP = process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local');-const BROWSER_UD = {+// Where each browser keeps its profiles. macOS puts them under Application Support with no "User Data"+// level; the Local State / Preferences JSON inside is the same shape (Drew Owens, nb-bridge#51).+const MAC_SUPPORT = path.join(os.homedir(), 'Library', 'Application Support');+const BROWSER_UD = process.platform === 'darwin' ? {+  chrome: path.join(MAC_SUPPORT, 'Google', 'Chrome'),+  edge: path.join(MAC_SUPPORT, 'Microsoft Edge'),+} : {   chrome: path.join(LOCALAPP, 'Google', 'Chrome', 'User Data'),   edge: path.join(LOCALAPP, 'Microsoft', 'Edge', 'User Data'), };@@ -908,9 +914,8 @@ function avatarForProfile(profileKey) {     const i = profileKeyResolved.indexOf(':');     const browser = i >= 0 ? profileKeyResolved.slice(0, i) : 'chrome';     const email = i >= 0 ? profileKeyResolved.slice(i + 1) : profileKeyResolved;-    const local = process.env.LOCALAPPDATA;-    if (local && email.includes('@')) {-      const root = browser === 'edge' ? path.join(local, 'Microsoft', 'Edge', 'User Data') : path.join(local, 'Google', 'Chrome', 'User Data');+    if (BROWSER_UD[browser] && email.includes('@')) {+      const root = BROWSER_UD[browser];       const j = JSON.parse(fs.readFileSync(path.join(root, 'Local State'), 'utf8'));       const cache = (j.profile && j.profile.info_cache) || {};       for (const [dir, info] of Object.entries(cache)) {@@ -1359,6 +1364,12 @@ let _chromeInFlight = null; // a fresh machine it is the browser; Chrome is optional and is only worth installing when the user asks for // Chrome by name or when NO supported browser exists at all. function detectEdge() {+  if (process.platform === 'darwin') {+    for (const c of ['/Applications/Microsoft Edge.app', path.join(os.homedir(), 'Applications', 'Microsoft Edge.app')]) {+      try { if (fs.existsSync(c)) return path.join(c, 'Contents', 'MacOS', 'Microsoft Edge'); } catch {}+    }+    return null;+  }   for (const p of ['C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', 'C:/Program Files/Microsoft/Edge/Application/msedge.exe']) { try { if (fs.existsSync(p)) return p; } catch {} }   return null; }@@ -1370,6 +1381,12 @@ function nativeBrowserSummary() {   return { chromeInstalled: !!chrome, edgeInstalled: !!edge, nativeBrowserPresent: !!(chrome || edge), chromeNeeded: !(chrome || edge), edgeProfiles: edgeKeys, chromeProfiles: chromeKeys }; } function detectChrome() {+  if (process.platform === 'darwin') {+    for (const c of ['/Applications/Google Chrome.app', path.join(os.homedir(), 'Applications', 'Google Chrome.app')]) {+      try { if (fs.existsSync(c)) return path.join(c, 'Contents', 'MacOS', 'Google Chrome'); } catch {}+    }+    return null;+  }   if (process.platform !== 'win32') return null;   const home = process.env.USERPROFILE || os.homedir();   const pf = process.env['ProgramFiles'] || 'C:\\Program Files';@@ -2048,7 +2065,7 @@ function dispatch(verb, args) {         d('nbrowser_prewarm', 'READ-ONLY tally of browsers, profiles and where nbe is installed / off / missing (ab runs it after an install). readiness recomputes it live.', {}, { ok: 'bool', summary: 'str', asOf: 'str', browsers: 'obj', tally: 'obj', installedIn: 'arr', disabledIn: 'arr', missingIn: 'arr', profiles: 'arr', offer: 'str?' }, 60, { example: {} }),         d('nbrowser_chrome_status', 'READ-ONLY: is native Google Chrome installed / how is an install going? Poll after nbrowser_install_chrome.', {}, { notifications: '{checked,toastsEnabled,adomBridgeEnabled,toastMayBeMuted,_hint} - Windows toast switches, so a caller knows when the Approve-now toast could not have been seen', canRetryUac: 'bool', installed: 'bool', executablePath: 'str?', phase: '"idle"|"installing"|"awaiting_uac"|"ready"|"failed"', installing: 'bool', awaitingUac: 'bool', errorCode: 'str?' }, 15, { example: {} }),         d('nbrowser_ping', 'Round-trip liveness check through to the extension.', {}, { ok: 'bool', pong: 'bool' }, 15),-        d('nbrowser_open_window', 'Open a NEW window in the BACKGROUND (unfocused) and return a sessionId to drive it. REGISTRATION REQUIRED: sessionId + thread + purpose, or refused (session_unregistered). Never steals focus; a topmost driven window is auto-reverted (focus_violation).', { left: 'optional int (logical px)', top: 'optional int', width: 'optional int (default: the newWindowSize setting; fill = the work area inset 10 px, pup R1)', height: 'optional int', state: 'optional "maximized"|"normal"', sessionId: 'required str (your short task id)', thread: 'required str (which AI thread you are)', purpose: 'required str (human-readable, e.g. "finishing John\'s IRS signup")', url: 'required str', profile: P, userRequestedForeground: 'optional bool - raise to foreground ONLY when the user asked or a browser/auth feature requires it (default false)', foregroundReason: 'REQUIRED with userRequestedForeground - human-readable why; without it the window STAYS background. Warn the user via ab notify_user FIRST.' }, { ok: 'bool', sessionId: 'str', tabId: 'str', windowId: 'int', hwnd: 'int (OS window handle - use with desktop_screenshot_window to capture the window+chrome+child popups)', url: 'str', _warning: 'str?', keptBackground: 'bool?' }, 30, { example: { sessionId: 'irs', thread: 'thread-7', purpose: 'finishing John IRS signup', url: 'https://wiki.adom.inc' } }),+        d('nbrowser_open_window', 'Open a NEW window in the BACKGROUND (unfocused) and return a sessionId to drive it. REGISTRATION REQUIRED: sessionId + thread + purpose, or refused (session_unregistered). Never steals focus; a topmost driven window is auto-reverted (focus_violation).', { left: 'optional int (logical px)', top: 'optional int', width: 'optional int (default: the newWindowSize setting; fill = the work area inset 10 px, pup R1)', height: 'optional int', state: 'optional "maximized"|"normal"', sessionId: 'required str (your short task id)', thread: 'required str (which AI thread you are)', purpose: 'required str (human-readable, e.g. "finishing John\'s IRS signup")', url: 'required str', profile: P, userRequestedForeground: 'optional bool - raise to foreground ONLY when the user asked or a browser/auth feature requires it (default false)', foregroundReason: 'REQUIRED with userRequestedForeground - human-readable why; without it the window STAYS background. Warn the user via ab notify_user FIRST.' }, { ok: 'bool', profile: 'str (the identity this window is in)', email: 'str', displayName: 'str', sessionId: 'str', tabId: 'str', windowId: 'int', hwnd: 'int (OS window handle - use with desktop_screenshot_window to capture the window+chrome+child popups)', url: 'str', _warning: 'str?', keptBackground: 'bool?' }, 30, { example: { sessionId: 'irs', thread: 'thread-7', purpose: 'finishing John IRS signup', url: 'https://wiki.adom.inc' } }),         d('nbrowser_close_window', 'Close a window the agent opened. includeSpawned:true also closes everything that session SPAWNED (composes/popups).', { sessionId: 'required str', includeSpawned: 'optional bool (also close this session\'s spawned windows)', profile: P }, { ok: 'bool', closed: 'bool', sessionId: 'str', alsoClosedSpawned: '[int]' }, 20, { example: { sessionId: 'work', includeSpawned: true } }),         d('nbrowser_owned', 'List everything a session owns: opened windows + adopted SPAWNED windows/tabs (compose/popup/target=_blank a driven page opened). Acknowledges spawns.', { sessionId: 'optional str (all sessions if omitted)', profile: P }, { ok: 'bool', opened: '[{sessionId,windowId,url,title,purpose,ageMs}]', spawned: '[{kind,windowId,tabId,url,ageMs,spawnedBy,opener}]' }, 20, { example: { sessionId: 'irs' } }),         d('nbrowser_cleanup', 'Close ONLY what a session SPAWNED (leaked composes/popups). Never the user\'s windows, never your primary opened window.', { sessionId: 'required str', profile: P }, { ok: 'bool', closed: '[{windowId,url}]', count: 'int', keptOpenedWindow: 'int?' }, 20, { example: { sessionId: 'irs' } }),@@ -2145,13 +2162,17 @@ function dispatch(verb, args) {       const list = [...conns.entries()].map(([k, c]) => {         const row = { profile: k, label: profileLabel(c.profile), email: c.profile.email || '', browser: c.profile.browser || 'chrome', active: k === defKey, blocked: isBlocked(k), live: !!(c.sock && !c.sock.destroyed) };         row.origin = c.origin ? c.origin.owner : 'checking';+        // What a row with no email/displayName IS (nb-bridge#53 ask 4): either pup's own browser, or a+        // profile whose identity has not resolved yet. The SAME email can appear twice legitimately: once+        // per browser (chrome:you@x and edge:you@x are different windows with different cookies).+        if (!row.email) row.note = isPupConn(c) ? "pup's own browser window, NOT the user's browser. Never the default target."+          : 'identity not resolved yet (the profile is signed out, or its hello has not landed). It is still drivable, but do not assume whose account it is.';         if (isPupConn(c)) row.note = "pup's own browser window, NOT the user's browser. Never the default target; name it explicitly only if you really mean pup's window (and prefer pup_* verbs for that).";         const av = avatarForProfile(k);         if (av) { row.profileDir = av.profileDir; row.hasAvatar = !!av.avatarPath; }         try {           if (row.email) {-            const local = process.env.LOCALAPPDATA;-            const root = row.browser === 'edge' ? path.join(local, 'Microsoft', 'Edge', 'User Data') : path.join(local, 'Google', 'Chrome', 'User Data');+            const root = BROWSER_UD[row.browser] || BROWSER_UD.chrome;             const jj = JSON.parse(fs.readFileSync(path.join(root, 'Local State'), 'utf8'));             for (const [dir, info] of Object.entries((jj.profile && jj.profile.info_cache) || {})) {               if (String((info && info.user_name) || '').toLowerCase() === row.email.toLowerCase()) { row.displayName = String((info && info.name) || ''); row.profileDir = dir; break; }@@ -2320,9 +2341,10 @@ function dispatch(verb, args) {       for (const w of curWins) { const t = String(w.title || ''); if (BRAND.test(t) && WORKSPACE.test(t)) protectedHwnds.add(w.hwnd); }       for (const [sid, pk] of sessionProfile) { if (pk === kp.key && sid !== a.sessionId && !osOpened.has(sid)) { const h = sessionHwnd.get(sid); if (h) protectedHwnds.add(h); } }       const local = process.env.LOCALAPPDATA;+      // detectChrome/detectEdge know the macOS app bundles too, so a Mac can launch its own browser (nb-bridge#51).       const exes = kp.browser === 'edge'-        ? ['C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', 'C:/Program Files/Microsoft/Edge/Application/msedge.exe']-        : ['C:/Program Files/Google/Chrome/Application/chrome.exe', 'C:/Program Files (x86)/Google/Chrome/Application/chrome.exe', local ? path.join(local, 'Google', 'Chrome', 'Application', 'chrome.exe') : ''];+        ? [detectEdge(), 'C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', 'C:/Program Files/Microsoft/Edge/Application/msedge.exe']+        : [detectChrome(), 'C:/Program Files/Google/Chrome/Application/chrome.exe', 'C:/Program Files (x86)/Google/Chrome/Application/chrome.exe', local ? path.join(local, 'Google', 'Chrome', 'Application', 'chrome.exe') : ''];       const exe = exes.find((e) => e && fs.existsSync(e));       if (!exe) return resolve({ success: false, error: `${kp.browser} executable not found at a standard path` });       // AUTHORITATIVE ORDER: a LIVE native-messaging connection for this profile proves the extension is@@ -2623,9 +2645,10 @@ function dispatch(verb, args) {       if (!kp) return resolve({ success: false, errorCode: _rk2.ambiguous ? 'profile_ambiguous' : 'profile_not_found', candidates: _rk2.candidates, error: `no local browser profile matches '${want}'`, _hint: (_rk2.candidates && _rk2.candidates.length ? `Profiles on this machine: ${_rk2.candidates.join(', ')}. ` : '') + 'nbrowser_profiles lists every profile on this machine (live + asleep). Check the email/browser.' });       if (isBlocked(kp.key)) return resolve({ success: false, error: `profile '${kp.key}' is blocklisted`, _hint: 'The user blocked this profile. nbrowser_profile_unblock first (with the user\'s consent).' });       const local = process.env.LOCALAPPDATA;+      // detectChrome/detectEdge know the macOS app bundles too, so a Mac can launch its own browser (nb-bridge#51).       const exes = kp.browser === 'edge'-        ? ['C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', 'C:/Program Files/Microsoft/Edge/Application/msedge.exe']-        : ['C:/Program Files/Google/Chrome/Application/chrome.exe', 'C:/Program Files (x86)/Google/Chrome/Application/chrome.exe', local ? path.join(local, 'Google', 'Chrome', 'Application', 'chrome.exe') : ''];+        ? [detectEdge(), 'C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', 'C:/Program Files/Microsoft/Edge/Application/msedge.exe']+        : [detectChrome(), 'C:/Program Files/Google/Chrome/Application/chrome.exe', 'C:/Program Files (x86)/Google/Chrome/Application/chrome.exe', local ? path.join(local, 'Google', 'Chrome', 'Application', 'chrome.exe') : ''];       const exe = exes.find((e) => e && fs.existsSync(e));       if (!exe) return resolve({ success: false, error: `${kp.browser} executable not found at a standard path` });       // --no-startup-window loads the profile (and its extensions) in BACKGROUND mode: NO window is@@ -2682,6 +2705,13 @@ function dispatch(verb, args) {       const match = args && (args.match || args.vendor || args.host);       const browser = args && args.browser;   // optional: "chrome" | "edge"       const profile = args && (args.profile || args.email); // optional: a specific profile email+      // On a platform whose credential store nb cannot read, an empty list READS AS "this user has no saved+      // logins" and the AI plans around a false fact. Refuse explicitly instead (Drew Owens, nb-bridge#51).+      if (process.platform !== 'win32') {+        return resolve({ success: false, errorCode: 'unsupported_platform',+          error: `nbrowser_credentials reads the browser's saved-login store, which nb can only read on Windows today (this box is ${process.platform}).`,+          _hint: 'This is NOT "the user has no saved logins" - nb simply cannot see them here. Ask the user whether they have a login for the site, or just drive the site and let the browser autofill it: their real browser still fills its own saved passwords.' });+      }       const rows = queryCredentials({ browser, profile, match });       return resolve({ success: true, output: JSON.stringify({ ok: true, count: rows.length, credentials: rows, _hint: 'Read-only query of the BROWSER\'s own saved-login store (Chrome + Edge) - we do NOT store or replace passwords; the browser stays the source of truth. Each row = {browser, profile, host, username} you CAN auto-login to (password is NOT exposed - Chrome/Edge autofill it when you focus the login field). Flow: credentials {match:"digikey"} -> if present, navigate to the sign-in page -> click the user/email field (autofills) -> click submit -> login_state. Filters: match:"<vendor>", browser:"chrome"|"edge", profile:"<email>".' }) });     }@@ -2966,6 +2996,27 @@ function dispatch(verb, args) {         logActivity({ verb: '_cross_thread', sessionId: args.sessionId, ok: true, ops: `${nowCaller} -> ${owner}`, internal: true });       }     }+    // WRONG-ACCOUNT GUARD (John, nb-bridge#53, 2026-10-14): an agent opened a window with no `profile`,+    // landed in whichever identity happened to be active ([email protected]), and got as far as Google's+    // account chooser for a sign-in meant to be John's. Driving the wrong account is a worse mistake than+    // an untracked window, which nb already refuses. So: with MORE THAN ONE identity connected, a window+    // or tab opened with no profile and no session pin is REFUSED, naming the exact values to pass. One+    // identity connected = defaulting is unambiguous and still allowed.+    if ((verb === 'nbrowser_open_window' || verb === 'nbrowser_open_tab') && !(args && (args.profile || args.profileEmail))+        && !(args && args.sessionId && sessionProfile.get(args.sessionId))) {+      const ids = userConns();+      if (ids.length > 1) {+        const choices = ids.map(([k, c]) => {+          const av = avatarForProfile(k) || {};+          return { profile: k, email: (c.profile && c.profile.email) || '', displayName: profileLabel(c.profile) || null, profileDir: av.profileDir || null };+        });+        return resolve({ success: false, errorCode: 'profile_required',+          error: `${ids.length} signed-in identities are connected, so '${verb}' will not guess which one to act as: ${choices.map((x) => x.profile).join(', ')}. Pass profile:"<one of these>".`,+          profiles: choices,+          _hint: 'Acting as the wrong account is expensive to undo (posting, buying, signing in). Ask the user which identity this task belongs to, or infer it from the task (work vs personal), then retry with profile:"<browser>:<email>". nbrowser_profiles lists them with their browser labels.',+          _next: choices.map((x) => `retry with profile:"${x.profile}"${x.displayName ? ` (${x.displayName})` : ''}`) });+      }+    }     // For open_window, snapshot the Chrome window list BEFORE forwarding so the post-open diff reliably     // catches the new window (the old fire-and-forget snapshot raced the window appearing).     if (verb === 'nbrowser_open_window') {@@ -2995,8 +3046,33 @@ function downscalePng(src, dst, max) {     });   }); }+// Who a reply acted AS. nb-bridge#53: an agent should see "[email protected]" in the open_window reply, not+// discover it at a sign-in page three calls later.+function identityOf(key) {+  const c = conns.get(key); if (!c) return null;+  const av = avatarForProfile(key) || {};+  return { profile: key, email: (c.profile && c.profile.email) || '', displayName: profileLabel(c.profile) || null, profileDir: av.profileDir || null, browser: (c.profile && c.profile.browser) || 'chrome' };+} async function decorateReply(p, frame, payloadIn, setPayload) {   let payload = payloadIn;+      // The identity this call acted as, on every window/tab open (nb-bridge#53).+      if ((p.verb === 'nbrowser_open_window' || p.verb === 'nbrowser_open_tab' || p.verb === 'nbrowser_open_os_window') && payload && payload.ok !== false) {+        const id = identityOf(p.profileKey);+        if (id) payload = { ...payload, profile: id.profile, email: id.email, displayName: id.displayName, actingAs: `${id.displayName || id.profile}${id.email ? ` <${id.email}>` : ''}` };+      }+      // nbrowser_status promises "connected profiles + active browser" in its own hint but never listed+      // them; only nbrowser_profiles did (nb-bridge#53 ask 2). The bridge owns this knowledge, so add it.+      if (p.verb === 'nbrowser_status' && payload && payload.ok !== false) {+        try {+          const def = defaultConnKey();+          const rows = [...conns.entries()].filter(([, c]) => c.sock && !c.sock.destroyed).map(([k, c]) => {+            const id = identityOf(k) || { profile: k };+            return { ...id, active: k === def, origin: c.origin ? c.origin.owner : 'checking', version: c.version || null };+          });+          const asleep = knownProfiles().filter((kp) => !conns.has(kp.key)).map((kp) => ({ profile: kp.key, email: kp.email || '', displayName: kp.displayName || null, profileDir: kp.profileDir, asleep: true }));+          payload = { ...payload, profiles: rows, asleepProfiles: asleep, activeProfile: def };+        } catch {}+      }       // Screenshot file-save: huge base64 over the relay times out, so when the caller passes       // toFile:true we write the PNG to a laptop temp file here and return its path instead of the       // base64. Pull it with `adom-bridge pull_file` (binary chunked) - fast + no relay timeout.@@ -3280,7 +3356,9 @@ function writeHostFile(hostPort) {   // Publish the Node ab gave us so the Chrome-launched host can reuse it (see NODEPATHFILE note above).   // Normalize to native Windows backslashes - node-path.txt is consumed by a .bat, and a quoted   // forward-slash exe path is not reliably executable in cmd.exe.-  try { fs.writeFileSync(NODEPATHFILE, process.execPath.split('/').join('\\')); } catch {}+  // Backslashes ONLY on Windows, where a .bat consumes this. On macOS the launcher is a shell script and+  // a converted path cannot be exec'd (Drew Owens, nb-bridge#51).+  try { fs.writeFileSync(NODEPATHFILE, process.platform === 'win32' ? process.execPath.split('/').join('\\') : process.execPath); } catch {} } // PID-aware cleanup: ONLY delete host.json if it still points at *this* process. Otherwise a churning // instance (ab respawn, a manual run, a crash-restart) deletes the discovery file that another LIVE@@ -3380,9 +3458,10 @@ function nbeInventory() { } function knownProfiles() {   const out = [];-  const local = process.env.LOCALAPPDATA;-  if (!local) return out;-  const roots = [['chrome', path.join(local, 'Google', 'Chrome', 'User Data')], ['edge', path.join(local, 'Microsoft', 'Edge', 'User Data')]];+  // BROWSER_UD knows each OS's layout (Windows User Data vs macOS Application Support), so profiles are+  // found on a Mac too (nb-bridge#51).+  const roots = [['chrome', BROWSER_UD.chrome], ['edge', BROWSER_UD.edge]];+  if (!roots.some(([, r]) => r)) return out;   for (const [browser, root] of roots) {     try {       const j = JSON.parse(fs.readFileSync(path.join(root, 'Local State'), 'utf8'));@@ -3433,9 +3512,8 @@ function resolveKnownProfile(want, browserHint) { // the AI deserves to know which one it is (real gripe: an ah thread flailed at Edge for a whole session). function adomExtStateForProfile(browser, profileDir) {   try {-    const local = process.env.LOCALAPPDATA;-    if (!local || !profileDir) return { checked: false };-    const root = browser === 'edge' ? path.join(local, 'Microsoft', 'Edge', 'User Data') : path.join(local, 'Google', 'Chrome', 'User Data');+    const root = BROWSER_UD[browser] || BROWSER_UD.chrome;+    if (!root || !profileDir) return { checked: false };     for (const f of ['Secure Preferences', 'Preferences']) {       let j; try { j = JSON.parse(fs.readFileSync(path.join(root, profileDir, f), 'utf8')); } catch { continue; }       const settings = (j.extensions && j.extensions.settings) || {};@@ -3467,9 +3545,8 @@ function adomExtStateForProfile(browser, profileDir) { // "your Claude extension can work this page interactively; nbe adds full automation for any AI." function claudeExtStateForProfile(browser, profileDir) {   try {-    const local = process.env.LOCALAPPDATA;-    if (!local || !profileDir) return { checked: false };-    const root = browser === 'edge' ? path.join(local, 'Microsoft', 'Edge', 'User Data') : path.join(local, 'Google', 'Chrome', 'User Data');+    const root = BROWSER_UD[browser] || BROWSER_UD.chrome;+    if (!root || !profileDir) return { checked: false };     for (const f of ['Secure Preferences', 'Preferences']) {       let j; try { j = JSON.parse(fs.readFileSync(path.join(root, profileDir, f), 'utf8')); } catch { continue; }       const settings = (j.extensions && j.extensions.settings) || {};