← All Pull Requests

BOM: fill the resistor Comment values (5.1k, 100) #1

Merged not released yet opened by Colby Knox 2026-11-05

Fills in the BOM's Comment column for the resistors. They were all blank and on one row, even though the board has two different values.

Comment Designator Qty
5.1k R1 R2 2
100 R3 R4 R5 R6 R7 R9 6

The values come from the schematic's device names (0603_5.1KΩ_100MW_75V_~1%_C23186 and 0603_100Ω_100MW_75V_~1%_C22775) and match this page's README. There is no R8 on this board. Only src/nametag-blank-large-led-bom.csv changes.

Not changed:

  • The Comment cells for J2, the LEDs and the machine pins are still blank.
  • The README lists the Adom basic part CQ03WAF1000T5E for the 100 ohm resistors, and the schematic calls out C22775. This PR records the value only, not a part number.

It can come back: the schematic's resistors have no value attribute, so a fresh BOM export from Fusion may blank these cells again. Setting the values in the design source would fix that, and it isn't part of this PR.

Generated with Claude Code

Diff Skip to comments (1)

--- a/src/nametag-blank-large-led-bom.csv+++ b/src/nametag-blank-large-led-bom.csv@@ -1,5 +1,7 @@⋯ 1 unchanged line ⋯ ,J2,USB4135GFA,1,USB4135-GF-A
 ,LED1 LED2 LED3 LED4 LED5 LED6,LED_LW_A6SG-V2BA-FK0PN0_OSR,6,2026-08-25_20-17-51_Library
 ,MP1 MP2 MP3 MP4,MACH_PIN_LRG_STD,4,Adom_Library_Master Library
-,R1 R2 R3 R4 R5 R6 R7 R9,RESC1608X60,8,Adom JLCPCB Basic Parts Generated - Mar22_2025+5.1k,R1 R2,RESC1608X60,2,Adom JLCPCB Basic Parts Generated - Mar22_2025
+100,R3 R4 R5 R6 R7 R9,RESC1608X60,6,Adom JLCPCB Basic Parts Generated - Mar22_2025
+

Comments

Colby Knox · 6d ago

Correction to this PR's description: the schematic's resistors do have value attributes (5.1KΩ 100mW 75V 0603 C23186 and 100Ω 100mW 75V 0603 C22775). I said they didn't, and that was my parsing error. So the blank Comment column did not come from missing values. Why this BOM came out blank is still unknown, and I don't know whether a new export would blank it again.

The BOM values in this PR are unaffected. They match the schematic and board, and all 19 designators match the placement file.

Log in to comment.