← Commit history

Correct BAV199 dual-series topology and regenerate pin-labelled assets

John Lauer ·2d5a58dc9b ·28d ago ·parent 75a028d
5 files changed +195−17
page.json+13−17
@@ -107,11 +107,11 @@         "seat": "z = 0",         "extents_mm": [           2.5,-          3,+          3.0,           1.2         ],-        "zmin_mm": 0,-        "centre_offset_mm": 0,+        "zmin_mm": 0.0,+        "centre_offset_mm": 0.0,         "footprint_binding": "identity",         "sha256": "dd5d1711204e1d8d26cd11490923bd84340820baa69538c385a4300ec2539bc0",         "checked": "2026-10-07",@@ -126,11 +126,11 @@         "seat": "z = 0",         "extents_mm": [           2.5,-          3,+          3.0,           1.2         ],-        "zmin_mm": 0,-        "centre_offset_mm": 0,+        "zmin_mm": 0.0,+        "centre_offset_mm": 0.0,         "footprint_binding": "identity",         "sha256": "739bcd017b17687b8e7e9a8bc10e0b49d5e13c0c644faea0f542a5a10216b8ff",         "checked": "2026-10-07",@@ -179,17 +179,13 @@     "docs/bav199-7-f-datasheet.pdf",     "viewers/symbol.html",     "viewers/footprint.html",-    "bav199-7-f-etched.step",-    "bav199-7-f-etched.glb",-    "bav199-7-f-etched.fit.json",-    "bav199-7-f.adom-lbr.json",-    "provenance-correction.json",-    "LICENSE-KICAD.md",     "bav199-7-f-hero.glb",-    "bav199-7-f-hero.overlay.json"+    "bav199-7-f-hero.overlay.json",+    "bav199-7-f-etched.glb"   ],-  "visibility": "public",+  "visibility": {+    "public": true+  },   "updated_at": "2026-09-24T17:33:48.695Z",-  "description": "Diodes Incorporated dual-series low-leakage diode; corrected A1, K2 and K1/A2 pin functions.",-  "org": "adom"-}\ No newline at end of file+  "description": "Diodes Incorporated dual-series low-leakage diode; corrected A1, K2 and K1/A2 pin functions."+}
review/issue-receipt.jsonadded+43
@@ -0,0 +1,43 @@+{+  "status": "ok",+  "data": {+    "discussion": {+      "id": 1775,+      "page_id": 122694,+      "author_name": "John Lauer",+      "title": "Incorrect common-cathode pin functions on dual-series BAV199",+      "body": "Versions: BAV199-7-F catalog/package 0.1.0; adom-wiki 1.7.69; adom-lbr 2.47.4. Found during custom electronic-load component review on 2026-10-11. No desktop Bridge is involved in the error.\n\nThe page metadata, README and native symbol label pin2 A2 and pin3 K/common cathode. Diodes Incorporated's primary BAV199 datasheet DS30232 Rev11-2 (November2022), page1 internal schematic, shows a dual-series device: pin1 A1, pin2 K2, pin3 K1/A2; forward conduction paths 1→3 and3→2.\n\nSource: https://www.diodes.com/datasheet/download/BAV199.pdf\n\nReproduce: download page.json and bav199-7-f.kicad_sym from version0.1.0 and compare the pin descriptions/internal topology with the manufacturer schematic. Matching symbol/footprint pin-number sets passes despite incorrect functions. The stored two-model extraction consensus is therefore not sufficient evidence of topology.\n\nPrepared correction: pin names/descriptions, D reference prefix, footprint binding, regenerated EAGLE/hub libraries and symbol viewer. Three pins survive native rendering/export and EAGLE lint passes. Existing package geometry is preserved; virtual marked board-use model is kept when rebuilding the hero. Publication/readback will be recorded separately. No board nets are changed by this repair. The load's current D3 mapping already uses the correct series arrangement.\n\nNo new interactive screenshot was captured because the user closed the task browser. Source files are attached for exact reproduction.\n\n\n[symbol-before.kicad_sym](/attachments/adom/bav199-7-f/cad2da24fd041513863db38fd8e0e82772b078bd8a683e2b245082bef08d35e1/symbol-before.kicad_sym)\n\n[provenance-correction.json](/attachments/adom/bav199-7-f/19a4cd8404c0f1d061cff7c825f6de2de09ed4a00b9ee7e22f6bc99dfe64a317/provenance-correction.json)",+      "category": "bug-report",+      "is_pinned": 0,+      "is_locked": 0,+      "reply_count": 0,+      "last_reply_at": null,+      "created_at": "2026-10-11 16:48:35",+      "updated_at": "2026-10-11 16:48:35",+      "status": "open",+      "labels": "[]",+      "closed_at": null,+      "closed_by_name": null,+      "mentions_json": "[]",+      "number": 1,+      "deleted_at": null,+      "deleted_by_id": null,+      "deleted_by_name": null,+      "edited_at": null,+      "url": "https://wiki.adom.inc/adom/bav199-7-f/issues/1"+    },+    "page_discussion_count": 1+  },+  "hints": [+    {+      "level": "info",+      "code": "WEB_URL",+      "message": "https://wiki.adom.inc/adom/bav199-7-f/issues/1"+    },+    {+      "level": "info",+      "code": "BODY_POSTED",+      "message": "body posted (1775 chars): Versions: BAV199-7-F catalog/package 0.1.0; adom-wiki 1.7.69; adom-lbr 2.47.4. Found during custom electronic-load component review on 2026-10-11. No desktop Br..."+    }+  ]+}
review/lbr-lint.txtadded+6
@@ -0,0 +1,6 @@+OK: Lint passed with 0 error(s), 0 warning(s)+{+  "passed": true,+  "errors": [],+  "warnings": []+}
review/publish.jsonadded+132
@@ -0,0 +1,132 @@+{+  "status": "ok",+  "data": {+    "published": "adom/bav199-7-f",+    "version": "0.1.1",+    "sha256": "sha256-c83e3662a87325be50290434e27ec16d6d13127f3bef99dbd4e758a2c6b73444",+    "visibility": "public",+    "url": "/adom/bav199-7-f",+    "install": "adom-wiki pkg install adom/bav199-7-f"+  },+  "hints": [+    {+      "level": "warn",+      "code": "PUBLIC_INTERNAL_CONTENT",+      "message": "Published PUBLIC, but the content reads as internal (matched: internal). Anyone can read its source. If that's wrong: seal the source with 'adom-wiki page visibility adom/bav199-7-f --hide-source', or make the whole page private: POST /api/pages/adom/bav199-7-f/visibility {\"visibility\":\"private\"}."+    },+    {+      "level": "info",+      "code": "COMPONENT_SKILLS_MISSING",+      "message": "This component ships CAD data but no skill. An agent that installs it gets files, not capability: it still does not know pin 1 orientation, decoupling, or how to drop the part into KiCad/Fusion.",+      "action": "Add skills/<part-usage>/SKILL.md to the tarball teaching how to USE the part (placement, pin mapping, gotchas, reference circuits). It renders on the Skills tab and delivers on install."+    },+    {+      "level": "warn",+      "code": "PAGE_JSON_IGNORED",+      "message": "The tarball ships page.json carrying discovery_triggers, discovery_pitch, hero, but pkg publish does not read page.json: those fields did nothing here. Only the package.json manifest counts.",+      "action": "Move the fields into package.json (page.json is only read on page-repo pushes).",+      "data": {+        "path": "page.json",+        "tarball_version": "0.1.1",+        "publish_version": "0.1.1",+        "fields": [+          "discovery_triggers",+          "discovery_pitch",+          "hero"+        ]+      }+    },+    {+      "level": "info",+      "code": "TAG_IS_A_CATEGORY",+      "message": "Tag(s) \"component\", \"diodes\" duplicate structured category values. The hardware browser suppresses category-name tags from the tag row, so they do nothing there.",+      "action": "Set component.category in page.json instead (the structured axis owns what-sort-of-part), and keep tags for cross-cutting traits like kicad, press-fit, or automotive.",+      "data": {+        "tags": [+          "component",+          "diodes"+        ]+      }+    },+    {+      "level": "info",+      "code": "DISCOVERY_PREVIEW",+      "message": "discovery preview: you rank #1 among 1 results for your triggers",+      "action": "drop generic triggers that collide; lean into the unique wins where you rank #1",+      "data": {+        "your_rank": 1,+        "results_returned": 1,+        "collisions": [],+        "weak_triggers": [],+        "unique_wins": [+          "bav199-7-f"+        ]+      }+    },+    {+      "level": "info",+      "code": "STALE",+      "message": "Flagged stale: Zero stars; Zero discussions.",+      "action": "Ship a new release/commit, or deprecate the package if it's no longer maintained."+    },+    {+      "level": "info",+      "code": "WORKSPACE_FEATURE",+      "message": "This page can ship its author's Hydrogen bench: commit hydrogen/workspace.json (the pane layout with apps referenced by wiki page) and readers of a clone or fork open the same layout, apps installed and serving, with one command. Hydrogen Cloud lists it under Project workspaces with an Apply button.",+      "action": "From the container where the bench is open: adom-cli hydrogen workspace export --out hydrogen/workspace.json, then adom-wiki repo push adom/bav199-7-f -m \"bench\" --files hydrogen/workspace.json. Readers: adom-cli hydrogen workspace apply adom/bav199-7-f. Details: the wiki-workspaces skill.",+      "data": {+        "path": "hydrogen/workspace.json",+        "apply": "adom-cli hydrogen workspace apply adom/bav199-7-f"+      }+    },+    {+      "level": "warn",+      "code": "DISTRIBUTOR_NUMBERS",+      "message": "No digikey, mouser part numbers on this component. Buyers and the parts widgets read component.distributor_links; a part with no numbers cannot be ordered from the page.",+      "action": "Add to package.json: \"component\": { \"distributor_links\": { \"mouser\": \"<Mouser part #>\", \"digikey\": \"<DigiKey part #>\", \"lcsc\": \"<LCSC C-number>\" } }. Use false for a distributor that genuinely does not carry the part (e.g. \"lcsc\": false) so the warning stops.",+      "data": {+        "missing": [+          "digikey",+          "mouser"+        ]+      }+    },+    {+      "level": "warn",+      "code": "LINT",+      "message": "component has no board/layout (.kicad_pcb or .brd): nobody can reproduce or re-fab the design from this page."+    },+    {+      "level": "warn",+      "code": "LINT",+      "message": "component has no schematic (.kicad_sch or .sch): the design can't be reviewed or reused, only the symbol/footprint can."+    },+    {+      "level": "warn",+      "code": "LINT",+      "message": "component has no footprint/symbol metadata (<name>_footprint.json / <name>_symbol.json): per-pad wire-attach data rides this, so importers can't place it programmatically."+    },+    {+      "level": "warn",+      "code": "LINT",+      "message": "component is missing distributor number(s): digikey, mouser (component.distributor_links). Sourcing tools (BOM panels, kicad-library-manager, parts search) key on these; add each real distributor part number, or set a distributor to false ONLY when the part is genuinely not carried there (e.g. \"mouser\": false)"+    },+    {+      "level": "info",+      "code": "HERO_BUILT",+      "message": "bav199-7-f-hero.glb: pads 3, silk items 8, pin1 footprint silkscreen, labels 3; align OK (offset 0.0 mm); page.json now declares it as component.parts.model_3d (model_3d_plain = the clean model)"+    },+    {+      "level": "info",+      "code": "MEDIA_EXCLUDED",+      "message": "kept 1 page-asset media file(s) (2233 KB) out of the tarball: docs/hero.png",+      "action": "hero/screenshots/videos are page assets served from the page, not install payload; pass --include-media if a package genuinely needs one at runtime"+    },+    {+      "level": "info",+      "code": "PUBLISH_LAYERS",+      "message": "published the package layer (the install payload: manifest + scripts + bundled skills). The page git repo (Files tab) is a SEPARATE layer and is not synced by publish.",+      "action": "host source by pushing files into the page repo (never a source tarball); ship downloadable per-platform binaries with `adom-wiki release upload <ref> <ver> <file> --platform <os>`"+    }+  ]+}
review/symbol-native-check.txtadded+1
@@ -0,0 +1 @@+OK: bav199-7-f.kicad_sym validated — 3 pins, 0 unique pin names