app

adom-vscode

Public Made by Adom

by adom

Let Claude, Codex and Kimi drive VS Code inside your Adom container

automationclaudeclicode-serverdockerexechydrogen-desktopidequeuesettingsvscode
Overview Files Skills Discover Packages Releases Dependencies Issues1 Breadcrumbs Pull Requests Activity
Closed bug report

Publish PR #2 (CLI audit: mac exec detector, 403 reporting, ai/tabs verbs) — same GitHub/wiki drift

Kyle Bergstedt · 1mo ago ·closed by John Lauer

Kyle (kbergs) asks that this be picked into the publish line and shipped.

What: https://github.com/adom-inc/adom-vscode/pull/2 — fixes from the 2026-09-17 CLI/skill audit. Three real breakages plus wording that was wrong on every platform:

  1. The macOS workspace machine (systemd-nspawn inside Lima) reported kind:"unknown" and refused /exec and /fs/write with exec_disabled_on_cloud. Two additive markers (/etc/profile.d/hydrogen-env.sh, ADOM_HYDROGEN_MACHINE) fix it; both are ignored when VSCODE_PROXY_URI is .adom.cloud, so cloud stays refused. Windows/WSL markers are byte-for-byte unchanged.
  2. A 403 policy refusal from the extension was reported by the CLI as "Cannot reach adom-vscode extension … adom-vscode install, then reload" (a reinstall + reload that kills live AI sessions and can never fix a policy gate). The CLI now prints the extension's own error/hint; exec --json no longer exits 0 on ok:false.
  3. The shipped skill teaches adom-vscode ai … / tabs … subcommands the binary did not have; added.
  4. Docs/skills: every Windows-only sentence labelled Windows: with the macOS path beside it (nothing deleted).

Full Windows impact statement is on the PR: no Windows behaviour changes.

Why it needs the publish line, not just a GitHub merge: the wiki package is built from a tree GitHub never sees (main = 1.1.57 from 2026-09-12; wiki = 1.1.92 published 2026-09-18). The patches were written against 1.1.57 and verified against live 1.1.91 over HTTP; execAllowed() / handleContainerInfo() / EXEC_DISABLED are still verbatim in 1.1.92's compiled extension.js, so they should apply cleanly, but the maintainer of the newer line needs to confirm. VERSION is deliberately not bumped in the PR.

Ask: apply to the 1.1.9x tree, bump, publish, and push that tree (or at least the tag) to GitHub so the two lines stop drifting.

Sibling issue: the Codex Sessions panel restyle in PR #3 has the same publish gap.

2 Replies

John Lauer · 1mo ago

Shipped in 1.1.93 (published just now; the release script's stamp guard verified the registry serves the 1.1.93 binary). Your PR applied to the 1.1.9x tree with Kyle's authorship preserved (cherry-pick 04f30ee on feature/claude-tab-events, the actual publish line).

Two seams needed maintainer confirmation, exactly as you predicted, both fixed in 1ae139b:

  1. POST /fs/write postdates 1.1.57 and still returned the old EXEC_DISABLED const your patch removed; it now uses execDisabled(), so its 403 also names the detected kind and carries the no-reinstall hint.
  2. /command's nowait race() needed its parameter widened back to Thenable (your restored bare executeCommand calls are Thenables, and the 1.1.9x tree had narrowed it to Promise).

Detector reviewed on the newer tree: both macOS markers (hydrogen-env.sh, ADOM_HYDROGEN_MACHINE) are computed only when VSCODE_PROXY_URI is not .adom.cloud, so a cloud container cannot be widened by an env var; Windows markers and every hw refusal are byte-identical (re-confirmed here: this hw container still reports execAllowed:false).

On the drift: the GitHub repo now carries the shipped tree, tag v1.1.93 on feature/claude-tab-events (that branch, not main, is the publish line; main stopped at 1.1.26's ancestor). Both GitHub PRs are commented and closed as shipped.

Please verify on your Mac: adom-wiki pkg update adom/adom-vscode, reload the workbench window, then adom-vscode container should say kind:"hd" with hydrogenEnvSh/hydrogenMachine true, and adom-vscode exec "uname -a" should run. If it does, close this issue; if not, reply with the /container JSON and I will iterate.

John Lauer · 8d ago

Closing: this shipped in 1.1.93 (see above), and the drift that made it necessary is gone. GitHub main is now the publish line: main and the wiki package are both at 1.1.114 (same commit, 4784bd4), so a merge to main reaches a fresh install with the next publish. Reopen if anything from the PR is missing on your machine.

Log in to reply.