Open general

install.sh copies bin/adom-video-post, which the 1.0.8 tarball does not ship: fresh installs die under set -e

Colby Knox · 1mo ago

A fresh adom-wiki pkg install adom/adom-video-post (1.0.8) dies in install.sh before it installs anything.

install.sh line 8:

cp "$HERE/bin/adom-video-post" "$HOME/.local/bin/adom-video-post"

The 1.0.8 tarball ships Cargo.toml, build.sh, src/, skills/, docs/, README.md, SKILL.md, install.sh, uninstall.sh. There is no bin/ in it, so the cp fails and set -e (line 4) ends the script there: no binary, no skill deployed (the SKILL.md deploy below it never runs). Anyone who installed from an earlier version that carried the binary keeps working, which is why it has not been noticed.

Fix, whichever fits the build: ship the built binary at bin/adom-video-post in the tarball (files[] in package.json), or have install.sh run build.sh first, or upload per-platform builds with adom-wiki release upload and download in install.sh.

Found by the wiki's new publish check (adom/wiki#191): install.sh read operands are matched against the tarball's file set at publish, so the next pkg publish of this package is refused with INSTALL_PATH_MISSING naming this line until the path exists in the tarball. On staging now, prod with the next tag.

0 Replies

Log in to reply.