AI Flow

@@ -14,7 +14,7 @@ members = [ ]  [workspace.package]-version = "0.1.86"+version = "0.1.87" edition = "2021" license = "MIT" repository = "https://wiki.adom.inc/adom/adom-aiflow"

@@ -397,3 +397,7 @@ When multiple physical lands share one logical pin number, use the reviewed Fiel ### Existing pours after board adoption  Use `verify-pours --plan <reviewed-plan.json>` for read-only validation of already present saved pours against a reconciled explicit plan. Read `docs/existing-pours.md`. It records input-bound verification, not creation ownership; never replay a native mutation simply to repair dashboard evidence. A stale plan must fail. Native DRC, measurement and electrical/thermal gates remain required.++### Artifact evidence is copied without overwriting++`artifact --file` stores a content-addressed snapshot, including files already inside the run. Two different files named `review.json` remain separate; later source edits do not rewrite prior evidence. Copy/readback failures refuse registration. The ledger records the SHA-256 and original source path. Use the registered path printed by the command with `--replaces`; no historical event is rewritten. A hash establishes identity, not engineering validity. Existing ledgers remain unchanged.

⋯ 1 unchanged line ⋯

@@ -1,6 +1,7 @@ //! adom-aiflow: the board loop as one command, with the clock, the negotiation and the finish line. //! Every reply starts with OK: or ERROR: and carries Hint: lines that depend on this board and run. mod continuation;+mod artifact_store; mod pourverify; mod dashboard; mod silkscreen_sections;@@ -3324,10 +3325,9 @@ fn main() {             if !src.is_file() { err(&format!("no such file: {file}"), &["Make the drawing first (a PNG at 1920x1080 reads best fullscreen), then register it.".into()]); }             let step = step.clone().or_else(|| r.data["currentStep"].as_str().map(str::to_string)).unwrap_or_else(|| err("no current step", &["`step <name>` first: an artifact belongs to a step visit.".into()]));             let visit = r.data["steps"][&step]["visits"].as_array().map(|a| a.len()).unwrap_or(1);-            // the file lives in the run directory so the page and the video can find it later-            let canon = std::fs::canonicalize(&src).unwrap_or(src.clone());-            let rdir = std::fs::canonicalize(&dir).unwrap_or(dir.clone());-            let dest = if canon.starts_with(&rdir) { canon } else { let d = dir.join(src.file_name().unwrap_or_default()); let _ = std::fs::copy(&src, &d); std::fs::canonicalize(&d).unwrap_or(d) };+            // Snapshot even in-run sources: later edits must not rewrite earlier evidence.+            let (dest, artifact_hash) = artifact_store::snapshot(&src, &dir)+                .unwrap_or_else(|e| err(&e, &["No artifact was registered. Resolve the storage error and retry; existing evidence is preserved.".into()]));             let is_image = matches!(dest.extension().and_then(|e| e.to_str()).map(|e| e.to_ascii_lowercase()).as_deref(), Some("png") | Some("jpg") | Some("jpeg") | Some("webp"));             let review_path=if kind=="library-overview" {                 let rp=review.as_ref().unwrap_or_else(||err("library-overview needs --review <review.json>", &["Review exact selected STEP/GLB variants in the native EDA and the overview. See docs/library-overview-review.md.".into()]));@@ -3337,7 +3337,7 @@ fn main() {                 Some(std::fs::canonicalize(rp).unwrap_or(rp.clone()).display().to_string())             }else{None};             let replaced = replaces.as_ref().map(|p| std::fs::canonicalize(p).unwrap_or(PathBuf::from(p)).display().to_string());-            r.log("artifact", json!({"step": step, "visit": visit, "kind": kind, "file": dest.display().to_string(), "caption": caption, "byAi": true, "replaces": replaced, "review":review_path}));+            r.log("artifact", json!({"step": step, "visit": visit, "kind": kind, "file": dest.display().to_string(), "caption": caption, "byAi": true, "replaces": replaced, "review":review_path, "sha256": artifact_hash, "sourceFile": src.display().to_string()}));             r.mark(&format!("artifact {kind} for {step}-{visit}: {caption}"));             r.save().unwrap();             ok(&format!("{kind} registered for {step} (visit {visit}): {}", dest.display()), &[if is_image { "It goes on the run page under this step with your caption above it, and into the final video as a fullscreen shot at this point of the step (the one place the video leaves the EDA window).".to_string() } else if kind=="library-overview" { "The reviewed moving overview goes into compose; the full tour remains separate.".into() } else { "It goes on the run page under this step with your caption; this artifact kind does not automatically enter the final video.".to_string() }, "Next: if this was an analysis, walk the copper it judged on camera under this same step: `tour nets --nets <the pour nets>`.".into()]);

@@ -0,0 +1,5 @@+# 0.1.87: preserve artifact evidence++Registering two external files with the same basename previously overwrote the first run copy; a source named `run.json` could also collide with the manifest. `artifact` now creates a content-addressed, verified snapshot and reports storage failures before recording success. In-run source files are copied too, so subsequent source edits preserve earlier evidence. Existing snapshots are never overwritten; conflicting contents refuse.++The ledger additionally records `sha256` and `sourceFile`. Reports and video composition keep using the registered `file` path. Pass that printed path to `--replaces`. Old ledgers and files are not migrated or rewritten. Identical contents with the same extension reuse a verified snapshot. This protects evidence identity, not the correctness of its engineering conclusions.

@@ -1,7 +1,7 @@ {   "slug": "adom-aiflow",   "type": "app",-  "version": "0.1.86",+  "version": "0.1.87",   "title": "AI Flow",   "description": "Adom's AI Flow: a tool to help the AI follow all of the steps it takes to build a board. One Rust binary with a crate per step (placement helpers, a grid router with Kelvin taps, pours with keepouts, KiCad's DRC gate, live landing through the KiCad Bridge, copper measurement, current and thermal analysis) and a finish line that refuses an unfinished board. Every command answers with hints for the AI; every turn, its thinking time and every rework loop go into run.jsonl, so Claude, Codex and any other engine are compared on the same flow. KiCad today; Altium, Fusion and Adom's own web apps next.",   "summary": "Adom's AI Flow: a tool to help the AI follow all of the steps it takes to build a board. The AI thinks its way from placement through routing, pours, current and thermal analysis to a delivered video; the binary does the fast, deterministic parts of every step, hands back hints, and keeps a ledger of every turn, every return to an earlier step, and the clock from the prompt to done.",

@@ -0,0 +1,31 @@+"""Actual artifact CLI regression: same basename, manifest collision and immutable history."""+import hashlib,json,os,pathlib,subprocess,sys,tempfile+binary=str(pathlib.Path(sys.argv[1]).resolve())+with tempfile.TemporaryDirectory(prefix='aiflow-artifact-cli-') as td:+    p=pathlib.Path(td);run=p/'run';env=dict(os.environ,AIFLOW_DASHBOARD='off')+    def call(*args):+        return subprocess.run([binary,'--run',str(run),'--ai-thread','artifact-regression',*args],env=env,capture_output=True,text=True,timeout=30)+    assert call('intake','--prompt-time','2026-10-10T00:00:00Z','--engine','test').returncode==0+    def artifacts():+        return [r for r in map(json.loads,(run/'run.jsonl').read_text().splitlines()) if r.get('event')=='artifact']+    for name,body in [('a','first'),('b','second')]:+        (p/name).mkdir();src=p/name/'review.json';src.write_text(body)+        result=call('artifact','--file',str(src),'--step','intake','--kind','engineering-review','--caption',name)+        assert result.returncode==0,result.stderr+    first,second=artifacts()[-2:]+    assert first['file']!=second['file']+    assert pathlib.Path(first['file']).read_text()=='first'+    assert pathlib.Path(second['file']).read_text()=='second'+    assert first['sha256']==hashlib.sha256(b'first').hexdigest()+    (p/'a/review.json').write_text('new first')+    assert pathlib.Path(first['file']).read_text()=='first'+    src=p/'run.json';src.write_text('not a run manifest')+    assert call('artifact','--file',str(src),'--step','intake','--caption','manifest-name').returncode==0+    assert json.loads((run/'run.json').read_text())['engine']=='test'+    assert call('artifact','--file',str(p/'a/review.json'),'--step','intake','--caption','updated','--replaces',first['file']).returncode==0+    assert artifacts()[-1]['replaces']==first['file']+    corrupted=pathlib.Path(second['file']);corrupted.write_text('externally changed')+    before=len(artifacts());result=call('artifact','--file',str(p/'b/review.json'),'--step','intake','--caption','must refuse')+    assert result.returncode!=0 and 'existing file preserved' in result.stdout+result.stderr+    assert len(artifacts())==before and corrupted.read_text()=='externally changed'+    print('PASS: CLI preserves distinct reviews and run manifest, binds hashes, supports replacement, refuses corrupted copies.')